Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIS-8339] FLOAT should also accept integer #43

Merged
merged 1 commit into from
Oct 24, 2024
Merged

[FIS-8339] FLOAT should also accept integer #43

merged 1 commit into from
Oct 24, 2024
+40 −1

Conversation

pkyosx
Copy link
Contributor

@pkyosx pkyosx commented Oct 23, 2024 •
edited
Loading

Reason

Integer should be considered as a valid float.

Changes

  • Accept int for FLOAT

Test Scope

Checks

  • Unit tests are included or not applicable.

@pkyosx pkyosx requested a review from CJHwong October 23, 2024 05:32
CJHwong
CJHwong reviewed Oct 24, 2024
View reviewed changes
CHANGELOG.md Outdated
@@ -1,6 +1,11 @@
Changelog
=========

3.4.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can update the version number to 3.5.0 for new features.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@pkyosx pkyosx merged commit d4229e5 into develop Oct 24, 2024
2 checks passed
@pkyosx pkyosx deleted the feat/FIS-8339 branch October 24, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CJHwong CJHwong CJHwong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkyosx @CJHwong